-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #8356 from getsentry/prepare-release/7.56.0
meta(changelog): Update changelog for 7.56.0
- Loading branch information
Showing
39 changed files
with
1,711 additions
and
287 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
packages/browser-integration-tests/suites/replay/slowClick/multiClick/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { expect } from '@playwright/test'; | ||
|
|
||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { getCustomRecordingEvents, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers'; | ||
|
|
||
| sentryTest('captures multi click when not detecting slow click', async ({ getLocalTestUrl, page }) => { | ||
| if (shouldSkipReplayTest()) { | ||
| sentryTest.skip(); | ||
| } | ||
|
|
||
| const reqPromise0 = waitForReplayRequest(page, 0); | ||
|
|
||
| await page.route('https://dsn.ingest.sentry.io/**/*', route => { | ||
| return route.fulfill({ | ||
| status: 200, | ||
| contentType: 'application/json', | ||
| body: JSON.stringify({ id: 'test-id' }), | ||
| }); | ||
| }); | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
|
||
| await page.goto(url); | ||
| await reqPromise0; | ||
|
|
||
| const reqPromise1 = waitForReplayRequest(page, (event, res) => { | ||
| const { breadcrumbs } = getCustomRecordingEvents(res); | ||
|
|
||
| return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.multiClick'); | ||
| }); | ||
|
|
||
| await page.click('#mutationButtonImmediately', { clickCount: 4 }); | ||
|
|
||
| const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1); | ||
|
|
||
| const slowClickBreadcrumbs = breadcrumbs.filter(breadcrumb => breadcrumb.category === 'ui.multiClick'); | ||
|
|
||
| expect(slowClickBreadcrumbs).toEqual([ | ||
| { | ||
| category: 'ui.multiClick', | ||
| type: 'default', | ||
| data: { | ||
| clickCount: 4, | ||
| metric: true, | ||
| node: { | ||
| attributes: { | ||
| id: 'mutationButtonImmediately', | ||
| }, | ||
| id: expect.any(Number), | ||
| tagName: 'button', | ||
| textContent: '******* ******** ***********', | ||
| }, | ||
| nodeId: expect.any(Number), | ||
| url: 'http://sentry-test.io/index.html', | ||
| }, | ||
| message: 'body > button#mutationButtonImmediately', | ||
| timestamp: expect.any(Number), | ||
| }, | ||
| ]); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { expect } from '@playwright/test'; | ||
|
|
||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { getCustomRecordingEvents, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers'; | ||
|
|
||
| sentryTest('window.open() is considered for slow click', async ({ getLocalTestUrl, page, browser }) => { | ||
| if (shouldSkipReplayTest()) { | ||
| sentryTest.skip(); | ||
| } | ||
|
|
||
| const reqPromise0 = waitForReplayRequest(page, 0); | ||
|
|
||
| await page.route('https://dsn.ingest.sentry.io/**/*', route => { | ||
| return route.fulfill({ | ||
| status: 200, | ||
| contentType: 'application/json', | ||
| body: JSON.stringify({ id: 'test-id' }), | ||
| }); | ||
| }); | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
|
||
| await page.goto(url); | ||
| await reqPromise0; | ||
|
|
||
| const reqPromise1 = waitForReplayRequest(page, (event, res) => { | ||
| const { breadcrumbs } = getCustomRecordingEvents(res); | ||
|
|
||
| return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click'); | ||
| }); | ||
|
|
||
| // Ensure window.open() still works as expected | ||
| const context = browser.contexts()[0]; | ||
| const waitForNewPage = context.waitForEvent('page'); | ||
|
|
||
| await page.click('#windowOpenButton'); | ||
|
|
||
| const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1); | ||
|
|
||
| // Filter out potential blur breadcrumb, as otherwise this can be flaky | ||
| const filteredBreadcrumb = breadcrumbs.filter(breadcrumb => breadcrumb.category !== 'ui.blur'); | ||
|
|
||
| expect(filteredBreadcrumb).toEqual([ | ||
| { | ||
| category: 'ui.click', | ||
| data: { | ||
| node: { | ||
| attributes: { | ||
| id: 'windowOpenButton', | ||
| }, | ||
| id: expect.any(Number), | ||
| tagName: 'button', | ||
| textContent: '****** ****', | ||
| }, | ||
| nodeId: expect.any(Number), | ||
| }, | ||
| message: 'body > button#windowOpenButton', | ||
| timestamp: expect.any(Number), | ||
| type: 'default', | ||
| }, | ||
| ]); | ||
|
|
||
| await waitForNewPage; | ||
|
|
||
| const pages = context.pages(); | ||
|
|
||
| expect(pages.length).toBe(2); | ||
| expect(pages[1].url()).toBe('https://example.com/'); | ||
| }); |
Oops, something went wrong.