Skip to content

Commit

Permalink
fix(ember/v7): Do not create rendering spans without transaction (#11750
Browse files Browse the repository at this point in the history
)

Backport of #11749
  • Loading branch information
mydea committed Apr 23, 2024
1 parent 9544973 commit 8f55e3e
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ export function _instrumentEmberRouter(
},
op: 'ui.ember.transition',
name: `route:${fromRoute} -> route:${toRoute}`,
onlyIfParent: true,
});
});

Expand Down Expand Up @@ -237,6 +238,7 @@ function _instrumentEmberRunloop(config: EmberSentryConfig): void {
name: 'runloop',
op: `ui.ember.runloop.${queue}`,
startTimestamp: currentQueueStart,
onlyIfParent: true,
})?.end(now);
}
currentQueueStart = undefined;
Expand Down Expand Up @@ -310,6 +312,7 @@ function processComponentRenderAfter(
op,
origin: 'auto.ui.ember',
startTimestamp: begin.now,
onlyIfParent: true,
})?.end(now);
}
}
Expand Down Expand Up @@ -394,6 +397,7 @@ function _instrumentInitialLoad(config: EmberSentryConfig): void {
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.ember',
},
onlyIfParent: true,
startTimestamp,
})?.end(endTimestamp);
performance.clearMarks(startName);
Expand Down

0 comments on commit 8f55e3e

Please sign in to comment.