Skip to content

Commit

Permalink
test(remix): Skip flaky firefox integration tests (#8506)
Browse files Browse the repository at this point in the history
  • Loading branch information
AbhiPrasad committed Jul 11, 2023
1 parent 87bdcba commit 1167436
Showing 1 changed file with 34 additions and 3 deletions.
37 changes: 34 additions & 3 deletions packages/remix/test/integration/test/client/meta-tags.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ import { test, expect } from '@playwright/test';
import { getFirstSentryEnvelopeRequest } from './utils/helpers';
import { Event } from '@sentry/types';

test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page }) => {
test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page, browserName }) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

await page.goto('/');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -16,7 +22,16 @@ test('should inject `sentry-trace` and `baggage` meta tags inside the root page.
expect(sentryBaggageContent).toEqual(expect.any(String));
});

test('should inject `sentry-trace` and `baggage` meta tags inside a parameterized route.', async ({ page }) => {
test('should inject `sentry-trace` and `baggage` meta tags inside a parameterized route.', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

await page.goto('/loader-json-response/0');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -30,7 +45,16 @@ test('should inject `sentry-trace` and `baggage` meta tags inside a parameterize
expect(sentryBaggageContent).toEqual(expect.any(String));
});

test('should send transactions with corresponding `sentry-trace` and `baggage` inside root page', async ({ page }) => {
test('should send transactions with corresponding `sentry-trace` and `baggage` inside root page', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

const envelope = await getFirstSentryEnvelopeRequest<Event>(page, '/');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -47,7 +71,14 @@ test('should send transactions with corresponding `sentry-trace` and `baggage` i

test('should send transactions with corresponding `sentry-trace` and `baggage` inside a parameterized route', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

const envelope = await getFirstSentryEnvelopeRequest<Event>(page, '/loader-json-response/0');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand Down

0 comments on commit 1167436

Please sign in to comment.