Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add explanation to migration docs why RewriteFrames shouldn't be used #312

Closed
wants to merge 1 commit into from

Conversation

lforst
Copy link
Member

@lforst lforst commented Jun 12, 2023

We see people having issues with debug IDs because they're still using the RewriteFrames integration from previous setups.

This PR adds a section to the migration docs clarifying that it should be removed when using debug IDs.

@lforst lforst requested review from AbhiPrasad and mydea June 12, 2023 07:40
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 it is not ideal that this is needed... is there a way we could automatically disable it if we detect debug ids are used? 🤔 but for now makes sense to add this at least.

@lforst
Copy link
Member Author

lforst commented Jun 12, 2023

😬 it is not ideal that this is needed... is there a way we could automatically disable it if we detect debug ids are used? 🤔 but for now makes sense to add this at least.

Hard agree. I tried to get this through on the processing side of things in the backend by putting the debug ID directly on the stack frame objects. That would prevent any values from getting out of sync but it would have big implications on the processing pipeline in the backend.

@mitsuhiko brought up that we could just put the debug IDs on the individual frame objects and move them to the debug meta field right before sending. I am gonna try that before I merge this PR.

@lforst
Copy link
Member Author

lforst commented Jun 16, 2023

PR became redundant because we fixed this in the SDK getsentry/sentry-javascript#8347

@lforst lforst closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants