-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce fatal SDK logger #4288
Merged
Merged
+114
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
Loading status checks…
…-versions-android
Loading status checks…
…-for-jars
Loading status checks…
…-mixed-versions
|
romtsn
approved these changes
Mar 27, 2025
Base automatically changed from
feat/remove-duplicate-add-package-calls
to
main
March 27, 2025 13:08
lcian
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
fatalLogger
toSentryOptions
which defaults to usingAndroidFatalLogger
for Android andSystemOutLogger
otherwise.💡 Motivation and Context
When mixed versions are detected with
debug
set tofalse
, no log messages about exact dependencies and versions would be visible. Instead of asking customers to restart withdebug
set totrue
, we now have a fatal logger that will always print its messages regardless ofdebug
ordiagnosticLevel
.💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps