Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce fatal SDK logger #4288

Merged
merged 26 commits into from
Mar 27, 2025
Merged

Introduce fatal SDK logger #4288

merged 26 commits into from
Mar 27, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Add fatalLogger to SentryOptions which defaults to using AndroidFatalLogger for Android and SystemOutLogger otherwise.

💡 Motivation and Context

When mixed versions are detected with debug set to false, no log messages about exact dependencies and versions would be visible. Instead of asking customers to restart with debug set to true, we now have a fatal logger that will always print its messages regardless of debug or diagnosticLevel.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

adinauer and others added 22 commits March 18, 2025 11:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
api
…-versions-android
…-mixed-versions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5e48870

Base automatically changed from feat/remove-duplicate-add-package-calls to main March 27, 2025 13:08
adinauer and others added 2 commits March 27, 2025 14:09
api
@adinauer adinauer merged commit 460594f into main Mar 27, 2025
34 of 35 checks passed
@adinauer adinauer deleted the feat/fatal-logger branch March 27, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants