-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added platform
to SentryEnvelopeItemHeader
#4287
added platform
to SentryEnvelopeItemHeader
#4287
Conversation
Added platform "android" in ProfileChunk envelope items
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
176d5ec | 399.08 ms | 518.53 ms | 119.45 ms |
61e8426 | 384.78 ms | 412.96 ms | 28.18 ms |
1421a3b | 426.76 ms | 462.20 ms | 35.44 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
176d5ec | 1.58 MiB | 2.22 MiB | 652.83 KiB |
61e8426 | 1.58 MiB | 2.22 MiB | 652.84 KiB |
1421a3b | 1.58 MiB | 2.22 MiB | 652.83 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor comment!
traceFile.getName()); | ||
traceFile.getName(), | ||
null, | ||
"android"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if/how hybrid SDKs are using this, but should this always be "android"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platform in the chunk item-type header should always match the platform in the chunk item-type payload.
So maybe instead of hard coding android
, using profileChunk.getPlatform()
could be better ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📜 Description
Added
platform
to SentryEnvelopeItemHeaderAdded platform "android" in ProfileChunk envelope items
💡 Motivation and Context
Implements client side of https://github.com/getsentry/team-ingest/issues/679
We want to rate limit UI and backend profile chunks differently.
In order to avoid having to maintain a list of sdk names, we are required to send the platform in the item header.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps