Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbstractMethodError when using SentryTraced for Jetpack Compose #4255

Merged

Conversation

markushi
Copy link
Member

📜 Description

SemanticsModifierNode provides default interface implementations, which could cause AbstractMethodError if the consuming app doesn't support the Java 1.8 features.

See https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/SemanticsModifierNode.kt;l=37-67;drc=adf6e7487c0412208c2b582e7d572649ab32503f

💡 Motivation and Context

Fixes #4249

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

@markushi markushi changed the title Override default interface impl to fix AbstractMethodError Fix AbstractMethodError when using SentryTraced for Jetpack Compose Mar 13, 2025
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 440.33 ms 508.86 ms 68.54 ms
Size 1.58 MiB 2.21 MiB 642.36 KiB

Previous results on branch: markushi/fix/missing-default-interface-method-overrides

Startup times

Revision Plain With Sentry Diff
6f0ae1c 396.54 ms 409.12 ms 12.58 ms

App size

Revision Plain With Sentry Diff
6f0ae1c 1.58 MiB 2.21 MiB 642.30 KiB

…d-overrides
@markushi markushi merged commit 2882875 into main Mar 13, 2025
34 checks passed
@markushi markushi deleted the markushi/fix/missing-default-interface-method-overrides branch March 13, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI tests failing from command line with latest Compose/on 8.2.0
2 participants