Avoid NPEs from SDK in API like setTag, setData, setContext #4245
+802
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
Performance metrics 🚀
|
lcian
reviewed
Mar 11, 2025
Comment on lines
680
to
684
| for (final Span span : this.children) { | ||
| // This is used in the spanFinishCallback, when the span isn't finished, but has a finish | ||
| // date | ||
| if (!span.isFinished() && span.getFinishDate() == null) { | ||
| return false; |
There was a problem hiding this comment.
Seems unrelated, should we revert this change?
There was a problem hiding this comment.
Ah yes, forgot to revert this.
Comment on lines
+678
to
+680
| if (key == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think we need to also unset if value is null here, like we do in the other overloads
There was a problem hiding this comment.
Or maybe it will be handled by the below call? Not sure.
There was a problem hiding this comment.
Yeah, this is handled by Contexts.put so no need to duplicate it here.
adinauer
commented
Mar 11, 2025
|
Flaky tests? Looks like the system tests are failing after ac9ebcd |
|
I'm guessing it's the OkHttp change. I've set the timeouts since it ran into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Using the SDK and having to guard against
nullis not a nice experience. Instead the SDK now tries to do the right thing when it receivesnullon APIs likesetTag,setData,setContext,setExtraetc.This means the SDK will:
keyisnull(maybe returningnullif a return type is specified)null💡 Motivation and Context
Fixes #4224
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps