Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use port when checking if a request is made to Sentry DSN #4231

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 5, 2025

📜 Description

We now check the hostname and port to see if a request is being made to Sentry.

💡 Motivation and Context

When running tests, we set the DSN to a localhost URL which then disabled injection of tracing information for requests that also go to localhost.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e518122

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.27 ms 456.70 ms 21.44 ms
Size 1.58 MiB 2.21 MiB 642.21 KiB

Previous results on branch: feat/consider-port-for-is-internal-span-check

Startup times

Revision Plain With Sentry Diff
1c49b13 368.33 ms 459.27 ms 90.94 ms
8d94da8 442.27 ms 455.23 ms 12.96 ms

App size

Revision Plain With Sentry Diff
1c49b13 1.58 MiB 2.21 MiB 642.10 KiB
8d94da8 1.58 MiB 2.21 MiB 642.02 KiB

@adinauer adinauer merged commit 762ee2d into main Mar 11, 2025
35 checks passed
@adinauer adinauer deleted the feat/consider-port-for-is-internal-span-check branch March 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants