-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create onCreate and onStart spans for all Activities #4025
Conversation
…s, not only for appStart ones
|
Just a note: Also, this works for automatic transactions only. If we want to instrument custom transactions, we can easily use |
Performance metrics 🚀
|
removed "closes" because that issue was about adding onResume spans which this PR does not |
📜 Description
ActivityLifecycleIntegration creates activity spans for all Activities, not only for appStart ones.
💡 Motivation and Context
We are currently adding
onCreate
andonStart
spans only in the app start transaction. This PR will add these spans to all automatic transactions, too💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps