Warm starts cleanup #3954

stefanosiano · 2024-12-03T16:59:55Z

📜 Description

moved activity lifecycle spans logic into a separate class ActivityLifecycleSpanHelper
moved processInitSpan creation to AppStartMetrics
ActivityLifecycleIntegration now create regular spans, and adds TimeSpans to AppStartMetrics to handle hybrid SDKs
PerformanceAndroidEventProcessor does not add activity lifecycle spans to the transaction, as they are added by ActivityLifecycleIntegration directly
removed activity callback from SentryPerformanceProvider

💡 Motivation and Context

Cleans some code after the warm start changes
I added a separate PR to avoid having too many logical changes in one

💚 How did you test it?

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

- creates `onCreate` and `onStart` TimeSpans - set app start type to warm in AppStartMetrics when needed AppStartMetrics has now a method to restart appStartSpan and reset its uptime_ms PerformanceAndroidEventProcessor now attaches activity start spans to warm starts, too SentryPerformanceProvider doesn't create spans anymore TimeSpan.setStartUnixTimeMs now shifts other timestamps accordingly

@testonly

…t app start timestamp reverted TimeSpan.setStartUnixTimeMs to @testonly method

…ld start was invalid (app was started in background, like via BroadcastReceiver)

… in perfv1, too updated tests

…fecycleSpanHelper moved processInitSpan creation to AppStartMetrics ActivityLifecycleIntegration now create regular spans, and adds TimeSpans to AppStartMetrics to handle hybrid SDKs PerformanceAndroidEventProcessor does not add activity lifecycle spans to the transaction, as they are added by ActivityLifecycleIntegration directly

# Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

github-actions · 2024-12-03T17:03:47Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

github-actions · 2024-12-05T12:07:42Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

github-actions · 2024-12-05T12:16:58Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	495.90 ms	555.29 ms	59.39 ms
Size	1.70 MiB	2.36 MiB	671.98 KiB

Previous results on branch: fix/warm-starts-cleanup

Startup times

Revision	Plain	With Sentry	Diff
`55f973b`	445.35 ms	510.94 ms	65.59 ms
`91b2d45`	432.93 ms	479.85 ms	46.92 ms
`b66bbdb`	419.41 ms	429.41 ms	10.00 ms
`3c20f24`	404.14 ms	488.88 ms	84.74 ms

App size

Revision	Plain	With Sentry	Diff
`55f973b`	1.70 MiB	2.36 MiB	672.08 KiB
`91b2d45`	1.70 MiB	2.36 MiB	672.05 KiB
`b66bbdb`	1.70 MiB	2.36 MiB	669.84 KiB
`3c20f24`	1.70 MiB	2.36 MiB	669.84 KiB

github-actions · 2024-12-05T12:20:11Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

# Conflicts: # CHANGELOG.md # sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java # sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java # sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java # sentry-android-core/src/test/java/io/sentry/android/core/ActivityLifecycleIntegrationTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/performance/AppStartMetricsTest.kt

github-actions · 2025-01-02T14:57:17Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

markushi

Nice one, looks goods to me! Left a few minor comments 🚀

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java

sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java

github-actions · 2025-01-03T10:47:18Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

github-actions · 2025-01-03T11:07:42Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

stefanosiano and others added 11 commits November 28, 2024 16:44

ActivityLifecycleIntegration now sets start type to warm even when co…

bb0b52a

…ld start was invalid (app was started in background, like via BroadcastReceiver)

ActivityLifecycleIntegration now restart app start in AppStartMetrics…

8acddb6

… in perfv1, too updated tests

updated changelog

ed06f9f

Format code

d64c243

removed Activity callback from SentryPerformanceProvider

0a51b76

Merge branch 'main' into fix/warm-starts

1af9a76

updated changelog

616c9f4

Merge branch 'refs/heads/fix/warm-starts' into fix/warm-starts-cleanup

2880946

# Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

add tests

7eb9680

Format code

5d30553

stefanosiano marked this pull request as ready for review December 5, 2024 12:17

stefanosiano requested review from adinauer, romtsn and markushi as code owners December 5, 2024 12:17

add tests

d0764bd

This was referenced Dec 6, 2024

Warm start detection #3937

Merged

Auto-Instrument onCreate and onStart in Activity transactions #2542

Closed

Base automatically changed from fix/warm-starts to main December 23, 2024 16:19

stefanosiano added 2 commits January 2, 2025 15:45

merged main

8ebf2cd

markushi approved these changes Jan 2, 2025

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java Show resolved Hide resolved

sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java Outdated Show resolved Hide resolved

Merge branch 'main' into fix/warm-starts-cleanup

d63607a

small cleanup on processInitTimeSpan creation

a35c8fa

stefanosiano enabled auto-merge (squash) January 3, 2025 10:52

updated process init span duration check for negative values

d132326

stefanosiano merged commit 00c8eeb into main Jan 3, 2025
32 checks passed

stefanosiano deleted the fix/warm-starts-cleanup branch January 3, 2025 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warm starts cleanup #3954

Warm starts cleanup #3954

stefanosiano commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024 •

edited

Loading

Previous results on branch: fix/warm-starts-cleanup

Startup times

App size

github-actions bot commented Dec 5, 2024

github-actions bot commented Jan 2, 2025

markushi left a comment •

edited

Loading

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

Warm starts cleanup #3954

Warm starts cleanup #3954

Conversation

stefanosiano commented Dec 3, 2024

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Dec 3, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Dec 5, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Dec 5, 2024 • edited Loading

Performance metrics 🚀

Previous results on branch: fix/warm-starts-cleanup

Startup times

App size

github-actions bot commented Dec 5, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Jan 2, 2025

🚨 Detected changes in high risk code 🚨

markushi left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2025

🚨 Detected changes in high risk code 🚨

github-actions bot commented Jan 3, 2025

🚨 Detected changes in high risk code 🚨

github-actions bot commented Dec 5, 2024 •

edited

Loading

markushi left a comment •

edited

Loading