POTEL 60 - Replace OTel ContextStorage wrapper with ContextStorageProvider
#3938
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
lbloder
approved these changes
Nov 29, 2024
| public final class SentryContextStorageProvider implements ContextStorageProvider { | ||
| @Override | ||
| public ContextStorage get() { | ||
| System.out.println("hello from SentryContextStorageProvider"); |
Comment on lines
26
to
+30
| * should try to use OTels StorageProvider mechanism instead. | ||
| */ | ||
| // ContextStorage.addWrapper((storage) -> new SentryContextStorage(storage)); | ||
| ContextStorage.addWrapper( | ||
| (storage) -> new SentryContextStorage(new SentryOtelThreadLocalStorage())); | ||
| // ContextStorage.addWrapper( | ||
| // (storage) -> new SentryContextStorage(new SentryOtelThreadLocalStorage())); |
There was a problem hiding this comment.
Let's keep the code in place just in case we need to restore. We can release this way for rc.1 and remove it before GA.
An error occurred while trying to automatically change base from
feat/bump-otel-2-10-0
to
8.x.x
November 29, 2024 12:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Replace OTel
ContextStoragewrapper withContextStorageProviderby using SPI.💡 Motivation and Context
Bumping OTel instrumentation to
2.10.0causes issues with our "no agent" use case where a logging appender causes early access toContextand thus prevents us from registering theContextStoragewrapper (since we try it too late and storage has already been marked as initialized). This gets rid of the ordering requirement and removes this brittleness from the SDK. It also allows us to upgrade OTel.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps