Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/breadcrumb level from http status #3771

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Oct 7, 2024

📜 Description

Fixes #3716

💡 Motivation and Context

Set level of http breadcrumb based on http status code if available.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

@lbloder lbloder changed the base branch from main to 8.x.x October 7, 2024 10:13
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against dffff2d

@lbloder lbloder marked this pull request as ready for review October 7, 2024 11:59
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.46 ms 505.88 ms 55.42 ms
Size 1.70 MiB 2.35 MiB 664.51 KiB

Previous results on branch: feat/breadcrumb-level-from-http-status

Startup times

Revision Plain With Sentry Diff
15341bc 441.15 ms 468.21 ms 27.06 ms
c1ca670 429.88 ms 462.02 ms 32.14 ms

App size

Revision Plain With Sentry Diff
15341bc 1.70 MiB 2.35 MiB 669.06 KiB
c1ca670 1.70 MiB 2.35 MiB 669.06 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@adinauer adinauer merged commit 2a08014 into 8.x.x Oct 10, 2024
21 of 22 checks passed
@adinauer adinauer deleted the feat/breadcrumb-level-from-http-status branch October 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Breadcrumbs should have their level set based on HTTP status code.
3 participants