Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traceHeaders method #3718

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Remove traceHeaders method #3718

merged 4 commits into from
Sep 30, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 25, 2024

📜 Description

Remove deprecated traceHeaders method.

💡 Motivation and Context

Closes #3365

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove `traceHeaders` method ([#3718](https://github.com/getsentry/sentry-java/pull/3718))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 93eb5a9

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.56 ms 505.06 ms 31.50 ms
Size 1.70 MiB 2.35 MiB 668.82 KiB

Previous results on branch: feat/remove-traceheaders-method

Startup times

Revision Plain With Sentry Diff
a013424 413.57 ms 456.44 ms 42.87 ms

App size

Revision Plain With Sentry Diff
a013424 1.70 MiB 2.35 MiB 668.92 KiB

Base automatically changed from feat/remove-reportfulldisplayed to 8.x.x September 30, 2024 06:27
An error occurred while trying to automatically change base from feat/remove-reportfulldisplayed to 8.x.x September 30, 2024 06:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@adinauer adinauer merged commit c2cad45 into 8.x.x Sep 30, 2024
3 checks passed
@adinauer adinauer deleted the feat/remove-traceheaders-method branch September 30, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants