Replace Android thread id with kernel thread id in span data #3706
+167
−132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
renamed IMainThreadChecker to IThreadChecker
added getCurrentThreadSystemId() to IThreadChecker
replaced thread id of SentryTracer and PerformanceAndroidEventProcessor
Adding to v8, since it's a behavioural change and users could already use it in some dashboard, as it's indexed. This is very unlikely, though.
💡 Motivation and Context
Continuous profiler needs to bind the trace and span to the corresponding thread in the profile.
The Android profiler retrieves the kernel thread id, that we can get via
Process.myTid()
, so we have to set that instead ofThread.getThreadId()
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps