-
-
Notifications
You must be signed in to change notification settings - Fork 452
POETL 37c - Skip PROCESS_COMMAND_ARGS
attribute
#3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adinauer
merged 10 commits into
8.x.x
from
feat/potel-37c-skip-process-command-args-attribute
Sep 3, 2024
Merged
POETL 37c - Skip PROCESS_COMMAND_ARGS
attribute
#3664
adinauer
merged 10 commits into
8.x.x
from
feat/potel-37c-skip-process-command-args-attribute
Sep 3, 2024
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java
…noring sentry specific ones
Loading status checks…
…PROCESS_COMMAND_ARGS
Loading status checks…
…span
|
Performance metrics 🚀
|
lbloder
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
One minor thing, since we now add an external key to the list, maybe the method isSentryInternalKey
could be renamed to something more fitting like shouldAttributeBeRemoved
or similar
Base automatically changed from
feat/potel-37b-remove-selective-attribute-copying
to
8.x.x
September 3, 2024 10:28
An error occurred while trying to automatically change base from
feat/potel-37b-remove-selective-attribute-copying
to
8.x.x
September 3, 2024 10:28
Loading status checks…
…tribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
PROCESS_COMMAND_ARGS
can be very large and cause other payload to be removed.💡 Motivation and Context
Defaults that work for most users.
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps