Skip to content

POTEL 32 - Attach active span to scope when using OpenTelemetry #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 4, 2024

📜 Description

We now set the active span on the current scope whenever a span is stored into context (span.makeCurrent()).

💡 Motivation and Context

Without this errors aren't linked to the correct trace.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

adinauer added 2 commits July 4, 2024 13:11
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1e602fa

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 467.18 ms 555.96 ms 88.77 ms
Size 1.70 MiB 2.29 MiB 599.31 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
57732e8 435.66 ms 510.50 ms 74.84 ms
a0f7731 357.02 ms 433.40 ms 76.38 ms
41e496a 408.90 ms 491.32 ms 82.42 ms
a59fca2 560.08 ms 658.80 ms 98.71 ms

App size

Revision Plain With Sentry Diff
57732e8 1.70 MiB 2.29 MiB 599.77 KiB
a0f7731 1.70 MiB 2.29 MiB 599.77 KiB
41e496a 1.70 MiB 2.29 MiB 599.77 KiB
a59fca2 1.70 MiB 2.29 MiB 599.77 KiB

Previous results on branch: feat/potel-32-attach-active-span-to-scope

Startup times

Revision Plain With Sentry Diff
dd8dafd 370.96 ms 475.33 ms 104.37 ms

App size

Revision Plain With Sentry Diff
dd8dafd 1.70 MiB 2.29 MiB 599.61 KiB

Base automatically changed from feat/potel-31-use-remote-parent-span-id to 8.x.x July 5, 2024 13:19
adinauer and others added 2 commits July 5, 2024 15:19
@adinauer adinauer merged commit 46d0f03 into 8.x.x Jul 5, 2024
21 checks passed
@adinauer adinauer deleted the feat/potel-32-attach-active-span-to-scope branch July 5, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant