Hsm 43 fix android tests #3417
Closed
Hsm 43 fix android tests #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and a disabled one
adinauer
requested changes
May 13, 2024
| @@ -416,8 +416,24 @@ public void close(final boolean isRestarting) { | |||
| } | |||
|
|
|||
| // TODO: should we end session before closing client? | |||
| configureScope(ScopeType.CURRENT, scope -> scope.getClient().close(isRestarting)); | |||
| configureScope(ScopeType.ISOLATION, scope -> scope.getClient().close(isRestarting)); | |||
| configureScope( | |||
There was a problem hiding this comment.
I think it makes more sense to accept the new behaviour of sending out old events on re-init of the SDK.
It's common for Spring Boot applications to also initialize the SDK first via a Sentry logging SDK and then
re-initialize Sentry in the Spring Boot SDK as this setup also reports startup problems to Sentry that happen before the Spring Boot SDK is able to initialize. For this case I think it makes perfect sense to send out data that was created before re-init.
|
Closing this in favor of fixing the test rather than changing behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps