-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Split Apks info as extras #3193
Conversation
hi @ganadist thanks for opening an issue for this and the PR! Before proceeding, I'd like to better understand your use-case - would you like to search for events with a specific split name? In general, we don't set tags by default in the SDKs, but rather extract them on backend, if there's a good case for those and cardinality is not high. |
@ganadist thanks, but can you please answer the question: would you like to search for events with a specific split name? If you don't need to search for it but just see it in the issue details, we could just send this info as part of App context then. Sending this as tag would require us to store and index it, and given that this field is high-cardinality (afaik apk splits are unique in their names and if multiply it by number of apks our customers might have that's huge), so this is unlikely that we'll take that route.
|
If it is possible to search for these events, it will be helpful to know the crash rate that occurs due to these problems. However, if this change may cause strain to the backend, it would be okay with being part of the app context instead of tags. |
Added 42a229f to use |
Unfortunately crash rate is based on Sessions dataset and it's not possible to filter session by custom tags/values yet. If search is not crucial for you, we should just add it as part of the App context - you will be able to see this information on individual events/issues then |
hi @ganadist sorry for abandoning this for so long, finally got the time to move the info to the app context. We'll ship this improvement as part of version 8.2.0. Thanks for your contribution! |
📜 Description
Fix #3192
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
Need to check test and unittest cases.