feat(tracing): Add WithDescription SpanOption #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natikgadzhi thanks for the PR! Just need to fix a linting issue and this should be good. :) |
|
@greywolve I do have to admit, not setting up a formatter in a Go project is kind of embarrasing. Fixed! |
Haha no problem, I forget this sometimes too :) |
|
Btw, perhaps worth setting up a .vscode/settings.json with custom formatter path to ensure gofmt -s by default?
|
greywolve
suggested changes
Nov 27, 2023
Co-authored-by: Oliver Powell <oliverpowell84@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 80.77% 80.88% +0.11%
==========================================
Files 47 48 +1
Lines 4701 4714 +13
==========================================
+ Hits 3797 3813 +16
+ Misses 765 763 -2
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
Not sure everyone uses vscode, but that could be useful for sure. |
cleptric
approved these changes
Nov 28, 2023
greywolve
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds
WithDescriptionspan option! Closes #739, thank you to @moneymikeMD for the issue.Changes
WithDescriptionSpanOptionthat works similar to the existingWithTransactionNameand friends.TODO
tracing_test.go. Wait a sec, will do in a couple hours./cc @greywolve