Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): check if git command exists when setting release #737

Merged
merged 1 commit into from Oct 18, 2023

Conversation

greywolve
Copy link
Contributor

First check if the git command exists before attempting to execute it. This ensures that we don't trigger any unwanted side effects, such as triggering a xcode cli tools install on macs.

First check if the git command exists before attempting to execute it.
This ensures that we don't trigger any unwanted side effects, such as
triggering a xcode cli tools install on macs.
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Files Coverage Δ
util.go 60.00% <0.00%> (-2.69%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@cleptric cleptric merged commit 8f8897d into getsentry:master Oct 18, 2023
16 of 17 checks passed
@greywolve
Copy link
Contributor Author

Fixes #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants