Dynamic error sampling Python #8314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sentrivana
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Please also add error_sampler to the Basic Options (best somewhere close to sample_rate)
shanamatthews
approved these changes
Oct 23, 2023
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
|
I believe I have addressed the concerns from the previous reviews; I would appreciate a quick re-review focusing on the changes I made since the last review |
shanamatthews
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Document the Python
error-sampleroption we introduced in getsentry/sentry-python#2456. Closes #8305.Extra resources