-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate autoAppStart
and setAppStartEnd
#2681
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
==========================================
+ Coverage 88.98% 92.15% +3.16%
==========================================
Files 262 90 -172
Lines 8906 2931 -5975
==========================================
- Hits 7925 2701 -5224
+ Misses 981 230 -751 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d44ba48 | 452.98 ms | 509.60 ms | 56.62 ms |
cc80714 | 333.26 ms | 388.80 ms | 55.54 ms |
43760f9 | 321.78 ms | 366.77 ms | 44.99 ms |
74e1fdd | 398.61 ms | 418.43 ms | 19.82 ms |
8776cdf | 353.32 ms | 416.58 ms | 63.26 ms |
521cfbf | 332.78 ms | 376.04 ms | 43.26 ms |
5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
7ec9238 | 414.02 ms | 513.94 ms | 99.91 ms |
f056db1 | 426.04 ms | 475.76 ms | 49.72 ms |
2e93bab | 515.33 ms | 558.79 ms | 43.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d44ba48 | 6.46 MiB | 7.49 MiB | 1.02 MiB |
cc80714 | 6.34 MiB | 7.28 MiB | 966.31 KiB |
43760f9 | 6.15 MiB | 7.13 MiB | 1000.49 KiB |
74e1fdd | 6.33 MiB | 7.27 MiB | 954.12 KiB |
8776cdf | 6.34 MiB | 7.28 MiB | 966.66 KiB |
521cfbf | 5.94 MiB | 6.97 MiB | 1.03 MiB |
5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
7ec9238 | 6.35 MiB | 7.42 MiB | 1.06 MiB |
f056db1 | 6.52 MiB | 7.61 MiB | 1.09 MiB |
2e93bab | 6.49 MiB | 7.55 MiB | 1.07 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1cdcacf | 1208.35 ms | 1235.13 ms | 26.77 ms |
ddc97ad | 1228.02 ms | 1232.61 ms | 4.59 ms |
5baa201 | 1250.63 ms | 1270.04 ms | 19.41 ms |
a80fbd1 | 1258.06 ms | 1273.44 ms | 15.38 ms |
07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
cdf7172 | 1264.43 ms | 1291.39 ms | 26.96 ms |
e4d5aa8 | 1224.15 ms | 1245.72 ms | 21.57 ms |
a40bb7c | 1222.75 ms | 1240.88 ms | 18.13 ms |
3500574 | 1263.02 ms | 1263.73 ms | 0.71 ms |
04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1cdcacf | 8.32 MiB | 9.39 MiB | 1.06 MiB |
ddc97ad | 8.29 MiB | 9.37 MiB | 1.08 MiB |
5baa201 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
a80fbd1 | 8.42 MiB | 9.89 MiB | 1.46 MiB |
07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
cdf7172 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
e4d5aa8 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
a40bb7c | 8.38 MiB | 9.73 MiB | 1.35 MiB |
3500574 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry about the confusion, lookin' good. 👍
📜 Description
💡 Motivation and Context
Part of #2631
💚 How did you test it?
No new tests needed
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps