Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish and start new transaction when tapping same element again #2623

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 28, 2025

📜 Description

  • Finish (when there are children) or cancel transaction when tapping same element again
  • Start new transaction

💡 Motivation and Context

Closes #2495

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
wkillerud William Killerud
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6a9443f

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (c15867f) to head (6a9443f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   89.10%   92.53%   +3.43%     
==========================================
  Files         263       91     -172     
  Lines        8943     2989    -5954     
==========================================
- Hits         7969     2766    -5203     
+ Misses        974      223     -751     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1250.79 ms 1278.90 ms 28.10 ms
Size 8.42 MiB 9.91 MiB 1.49 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9d43f71 1225.06 ms 1227.06 ms 2.00 ms
891efac 1233.78 ms 1248.31 ms 14.53 ms
0028e3e 1242.29 ms 1254.98 ms 12.69 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
4d75417 1240.57 ms 1261.76 ms 21.19 ms
bd75526 1252.62 ms 1287.00 ms 34.38 ms
3e4b523 1260.53 ms 1270.06 ms 9.53 ms
e893df5 1247.90 ms 1262.31 ms 14.41 ms
dfcfde9 1238.83 ms 1255.30 ms 16.47 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms

App size

Revision Plain With Sentry Diff
9d43f71 8.29 MiB 9.39 MiB 1.10 MiB
891efac 8.28 MiB 9.34 MiB 1.06 MiB
0028e3e 8.42 MiB 9.91 MiB 1.49 MiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
4d75417 8.38 MiB 9.71 MiB 1.34 MiB
bd75526 8.38 MiB 9.76 MiB 1.39 MiB
3e4b523 8.28 MiB 9.33 MiB 1.05 MiB
e893df5 8.09 MiB 9.07 MiB 1001.04 KiB
dfcfde9 8.42 MiB 9.91 MiB 1.49 MiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB

Previous results on branch: feat/ui-event-on-same-element

Startup times

Revision Plain With Sentry Diff
fe2bc2d 1241.17 ms 1262.28 ms 21.11 ms

App size

Revision Plain With Sentry Diff
fe2bc2d 8.42 MiB 9.91 MiB 1.49 MiB

@denrase denrase changed the title Finish or cancel transaction when tapping same element again Finish and start new transaction when tapping same element again Jan 28, 2025
@denrase denrase marked this pull request as ready for review January 28, 2025 13:40
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 423.27 ms 507.98 ms 84.71 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
72dfc83 298.62 ms 340.14 ms 41.52 ms
a5031f1 379.02 ms 443.12 ms 64.10 ms
547db82 453.40 ms 482.88 ms 29.48 ms
7f14ddd 428.38 ms 511.90 ms 83.51 ms
d0476e1 412.20 ms 492.62 ms 80.42 ms
09c1f55 449.98 ms 509.38 ms 59.40 ms
0118295 365.71 ms 438.56 ms 72.85 ms
22ed6cb 326.27 ms 393.00 ms 66.73 ms
e964e2b 365.15 ms 431.00 ms 65.85 ms
dd25e43 449.40 ms 504.18 ms 54.78 ms

App size

Revision Plain With Sentry Diff
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
a5031f1 6.33 MiB 7.29 MiB 987.32 KiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB
7f14ddd 6.35 MiB 7.40 MiB 1.05 MiB
d0476e1 6.35 MiB 7.40 MiB 1.05 MiB
09c1f55 6.49 MiB 7.55 MiB 1.07 MiB
0118295 6.33 MiB 7.26 MiB 947.07 KiB
22ed6cb 6.06 MiB 7.03 MiB 993.37 KiB
e964e2b 6.33 MiB 7.28 MiB 962.81 KiB
dd25e43 6.46 MiB 7.48 MiB 1.02 MiB

Previous results on branch: feat/ui-event-on-same-element

Startup times

Revision Plain With Sentry Diff
fe2bc2d 436.18 ms 528.14 ms 91.97 ms

App size

Revision Plain With Sentry Diff
fe2bc2d 6.46 MiB 7.48 MiB 1.03 MiB

@denrase denrase merged commit 8c9f280 into main Feb 5, 2025
61 checks passed
@denrase denrase deleted the feat/ui-event-on-same-element branch February 5, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Event Transactions Same Event on Same Element Change
2 participants