feat: Don't upload chunks that are already on the server (fixed version) #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that we have tests for both |
Swatinem
approved these changes
Jun 27, 2023
iambriccardo
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a corrected version of #1651. The problem in that version was that we didn't check if a
missing_chunks: []reply from the server actually meant anything. This led to not uploading anything if the server returned[]as a default value. Therefore, this version adds a newChunkUploadCapabilityvariantArtifactBundlesV2. Only if the server supports this capability are the chunks deduplicated.The changelog looks weird right now because the revert of #1651 is not yet published.