Invalidate instrumentation cache when changing instrumentation features #753
+89
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
features
,logcatEnabled
andappStartEnabled
params toSpanAddingClassVisitorFactory
parameters to make sure that if these change, the instrumentation is run again and the cache is invalidated.💡 Motivation and Context
Currently, when instrumentation parameters
features
,logcatEnabled
orappStartEnabled
change, instrumentation is not run again and the cached instrumentation result is used. I.e. it is not possible to change the feature set without deleting the gradle cache in the home directory.Fixes #3595
💚 How did you test it?
Added automated test
📝 Checklist
🔮 Next steps