Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sentry-cli works well with configuration cache #675

Merged
merged 14 commits into from
Mar 22, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 19, 2024

📜 Description

Fixes #651
Fixes #670

Going from

./gradlew :app:assembleRelease --configuration-cache
Configuration cache is an incubating feature.
Calculating task graph as configuration cache cannot be reused because a build logic input of type 'SentryCliValueSource' has changed.

to

./gradlew :app:assembleRelease --configuration-cache
Configuration cache is an incubating feature.
Reusing configuration cache.

💡 Motivation and Context

Our Gradle plugin should be cache-friendly.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@markushi markushi changed the title make cli cache path predictable Ensure sentry-cli works well with configuration cache Mar 19, 2024
?.substringAfter("[sentry] Using memoized cli path:")
?.trim()

val cli = File(cliPath!!).also { it.delete() }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we still have a test that deletes sentry-cli and then run the build again to verify it does not fail, but extracts the cli again?

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left one comment about a test.

And also, would be great if we test that after updating the cli/gradleplugin version it uses the new version instead of an old one. idk if we can easily create a test for that, but verifying it locally would be enough already

@markushi markushi merged commit 20281b5 into main Mar 22, 2024
18 checks passed
@markushi markushi deleted the fix/sentry-cli-config-cache branch March 22, 2024 08:17
@javadjafari1
Copy link

javadjafari1 commented May 13, 2024

it just wasted 2 days of mine. but glad to fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants