-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed OkHttpEventListener crash at compile time with OkHttp4 #514
Conversation
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@@ -90,7 +90,8 @@ dependencies { | |||
testImplementationAar(Libs.SQLITE) | |||
testImplementationAar(Libs.SQLITE_FRAMEWORK) | |||
testRuntimeOnly(files(androidSdkPath)) | |||
testRuntimeOnlyAar(Libs.SENTRY_ANDROID) | |||
testImplementation(Libs.SENTRY_ANDROID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I think this should be at least testImplementationAar
because the plugin is a .jar and it doesn't know how to include .aar as a dependency. Any reason you've changed it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests were failing due to ClassNotFound
for sentry.io.IntegrationName
after adding the sentry-android-okhttp
dependency
after adding sentry as testImplementation
tests were succeding again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, alright!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
📜 Description
OkHttp 4 switched to Kotlin, and changed few implementation details. We now check the version and apply the appropriate instrumentation
💡 Motivation and Context
Fixes #513
💚 How did you test it?
📝 Checklist
🔮 Next steps