Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OkHttpEventListener crash at compile time with OkHttp4 #514

Merged
merged 5 commits into from
Jun 20, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

OkHttp 4 switched to Kotlin, and changed few implementation details. We now check the version and apply the appropriate instrumentation

💡 Motivation and Context

Fixes #513

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
JonnyBurger Jonny Burger
@stefanosiano stefanosiano marked this pull request as ready for review June 19, 2023 16:48
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@@ -90,7 +90,8 @@ dependencies {
testImplementationAar(Libs.SQLITE)
testImplementationAar(Libs.SQLITE_FRAMEWORK)
testRuntimeOnly(files(androidSdkPath))
testRuntimeOnlyAar(Libs.SENTRY_ANDROID)
testImplementation(Libs.SENTRY_ANDROID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I think this should be at least testImplementationAar because the plugin is a .jar and it doesn't know how to include .aar as a dependency. Any reason you've changed it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests were failing due to ClassNotFound for sentry.io.IntegrationName after adding the sentry-android-okhttp dependency
after adding sentry as testImplementation tests were succeding again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, alright!

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic OkHttpEventListener breaks Pusher push notifications SDK initialization
2 participants