Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle 8 dependency issue for uploadNativeSymbols task #447

Merged
merged 1 commit into from Mar 14, 2023
Merged

Fix Gradle 8 dependency issue for uploadNativeSymbols task #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
View file
Open in desktop
Expand Up @@ -180,7 +180,6 @@ private fun ApplicationVariant.configureNativeSymbolsTask(
SentryUploadNativeSymbolsTask::class.java
) {
it.workingDir(project.rootDir)
it.buildDir.set(project.buildDir)
it.autoUploadNativeSymbol.set(extension.autoUploadNativeSymbols)
it.cliExecutable.set(cliExecutable)
it.sentryProperties.set(sentryProps?.let { file -> project.file(file) })
Expand Down
5 changes: 1 addition & 4 deletions plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadNativeSymbolsTask.kt
View file
Open in desktop
Expand Up @@ -20,9 +20,6 @@ abstract class SentryUploadNativeSymbolsTask : Exec() {
description = "Uploads native symbols to Sentry"
}

@get:InputDirectory
abstract val buildDir: DirectoryProperty

@get:Input
abstract val cliExecutable: Property<String>

Expand Down Expand Up @@ -91,7 +88,7 @@ abstract class SentryUploadNativeSymbolsTask : Exec() {
// where {variantName} could be debug/release...
args.add(
File(
buildDir.asFile.get(),
project.buildDir,
"intermediates${sep}merged_native_libs${sep}${variantName.get()}"
).absolutePath
)
Expand Down