Add installation name to porter upgrade command in Quickstart
#3182
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following the Quickstart for the first time, I received an error in the "Upgrade the Installation" section: ``` $ porter upgrade no bundle specified. Either an installation name, --reference, --file or --cnab-file must be specified or the current directory must contain a porter.yaml file ``` I believe the intention was for this command to include an installation name. It does succeed when running `porter upgrade porter-hello` so I've updated the command Signed-off-by: Eric Herrmann <26093534+egherrmann@users.noreply.github.com>
egherrmann
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
schristoff
approved these changes
Jul 11, 2024
|
Thank you so much! Please don't forget to add your name to the contributors file! |
egherrmann
added a commit
to egherrmann/porter
that referenced
this pull request
Jul 11, 2024
Recommended in [getporter#3182](getporter#3182): > [Thank you so much! Please don't forget to add your name to the contributors file!][getporter#3182 (comment)] Signed-off-by: Eric Herrmann <26093534+egherrmann@users.noreply.github.com>
schristoff
pushed a commit
that referenced
this pull request
Jul 11, 2024
Recommended in [#3182](#3182): > [Thank you so much! Please don't forget to add your name to the contributors file!][#3182 (comment)] Signed-off-by: Eric Herrmann <26093534+egherrmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fixes a typo in one of the Quickstart commands. When following Quickstart for the first time, I received an error in the Upgrade the Installation section:
I believe the intention was for this command to include an installation name. It does succeed when running
porter upgrade porter-helloso I've updated the command in the doc.What issue does it fix
"It's OK to submit a PR directly for problems such as misspellings or other things where the motivation/problem is unambiguous."
Notes for the reviewer
Locally, my
porter upgrade porter-hellooutput is slightly different than what's in the Quickstart, but I don't fully understand those lines and it's probably out of scope for this PR anyway:Checklist
I'd consider all of these as "not applicable" to a typo-fix: