Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudFormation: Implement Fn::GetAtt for AWS::EC2::LaunchTemplate #7121

Merged
merged 5 commits into from
Dec 17, 2023
Merged

CloudFormation: Implement Fn::GetAtt for AWS::EC2::LaunchTemplate #7121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3256d86
Added GetAtt support for launch templates
Ivan-Lukianov Dec 13, 2023
c5373a5
set -> list to preserve determinism
skinitimski Dec 13, 2023
f9c9a53
Apply black
skinitimski Dec 13, 2023
6c182d1
They are all strings
skinitimski Dec 13, 2023
5ed9d37
Isolate test resources
skinitimski Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions moto/cloudformation/parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,11 +740,9 @@ def build_resource_diff(self, other_template: Dict[str, Any]) -> Dict[str, Any]:
new = other_template["Resources"]

resource_names_by_action = {
"Add": set(new) - set(old),
"Modify": set(
name for name in new if name in old and new[name] != old[name]
),
"Remove": set(old) - set(new),
"Add": [name for name in new if name not in old],
"Modify": [name for name in new if name in old and new[name] != old[name]],
"Remove": [name for name in old if name not in new],
}

return resource_names_by_action
Expand Down
19 changes: 19 additions & 0 deletions moto/ec2/models/launch_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,25 @@

backend.delete_launch_template(name, None)

@classmethod
def has_cfn_attr(cls, attr: str) -> bool:
return attr in [

Check warning on line 197 in moto/ec2/models/launch_templates.py

View check run for this annotation

Codecov / codecov/patch

moto/ec2/models/launch_templates.py#L197 

Added line #L197 was not covered by tests
"DefaultVersionNumber",
"LaunchTemplateId",
"LatestVersionNumber",
]

def get_cfn_attribute(self, attribute_name: str) -> str:
from moto.cloudformation.exceptions import UnformattedGetAttTemplateException

if attribute_name == "DefaultVersionNumber":
return str(self.default_version_number)
if attribute_name == "LaunchTemplateId":
return self.id

Check warning on line 209 in moto/ec2/models/launch_templates.py

View check run for this annotation

Codecov / codecov/patch

moto/ec2/models/launch_templates.py#L209 

Added line #L209 was not covered by tests
if attribute_name == "LatestVersionNumber":
return str(self.latest_version_number)
raise UnformattedGetAttTemplateException()

Check warning on line 212 in moto/ec2/models/launch_templates.py

View check run for this annotation

Codecov / codecov/patch

moto/ec2/models/launch_templates.py#L212 

Added line #L212 was not covered by tests


class LaunchTemplateBackend:
def __init__(self) -> None:
Expand Down
247 changes: 247 additions & 0 deletions tests/test_ec2/test_launch_templates_cloudformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,247 @@
import json
from uuid import uuid4

import boto3

from moto import mock_autoscaling, mock_cloudformation, mock_ec2
from tests import EXAMPLE_AMI_ID, EXAMPLE_AMI_ID2


@mock_autoscaling
@mock_cloudformation
@mock_ec2
def test_asg_with_latest_launch_template_version():
cf_client = boto3.client("cloudformation", region_name="us-west-1")
ec2 = boto3.resource("ec2", region_name="us-west-1")
vpc = ec2.create_vpc(CidrBlock="10.0.0.0/16")
autoscaling_client = boto3.client("autoscaling", region_name="us-west-1")

subnet1 = ec2.create_subnet(
CidrBlock="10.0.1.0/24", VpcId=vpc.id, AvailabilityZone="us-west-1a"
)

subnet2 = ec2.create_subnet(
CidrBlock="10.0.2.0/24", VpcId=vpc.id, AvailabilityZone="us-west-1b"
)

autoscaling_group_name = str(uuid4())

stack_name = str(uuid4())
launch_template_name = str(uuid4())[0:6]

version_attribute = "LatestVersionNumber"

template_json = json.dumps(
{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an ASG group with LaunchTemplate",
"Resources": {
"LaunchTemplate": {
"Type": "AWS::EC2::LaunchTemplate",
"Properties": {
"LaunchTemplateName": launch_template_name,
"LaunchTemplateData": {
"ImageId": EXAMPLE_AMI_ID,
"InstanceType": "t3.small",
"UserData": "",
},
},
},
"AutoScalingGroup": {
"Type": "AWS::AutoScaling::AutoScalingGroup",
"Properties": {
"AutoScalingGroupName": autoscaling_group_name,
"VPCZoneIdentifier": [subnet1.id],
"LaunchTemplate": {
"LaunchTemplateId": {"Ref": "LaunchTemplate"},
"Version": {
"Fn::GetAtt": ["LaunchTemplate", version_attribute]
},
},
"MinSize": 1,
"MaxSize": 1,
},
},
},
}
)

cf_client.create_stack(
StackName=stack_name,
TemplateBody=template_json,
Capabilities=["CAPABILITY_NAMED_IAM"],
OnFailure="DELETE",
)

template_json = json.dumps(
{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an ASG group with LaunchTemplate",
"Resources": {
"LaunchTemplate": {
"Type": "AWS::EC2::LaunchTemplate",
"Properties": {
"LaunchTemplateName": launch_template_name,
"LaunchTemplateData": {
"ImageId": EXAMPLE_AMI_ID2,
"InstanceType": "t3.medium",
"UserData": "",
},
},
},
"AutoScalingGroup": {
"Type": "AWS::AutoScaling::AutoScalingGroup",
"Properties": {
"AutoScalingGroupName": autoscaling_group_name,
"VPCZoneIdentifier": [subnet2.id],
"LaunchTemplate": {
"LaunchTemplateId": {"Ref": "LaunchTemplate"},
"Version": {
"Fn::GetAtt": ["LaunchTemplate", version_attribute]
},
},
"MinSize": 1,
"MaxSize": 2,
},
},
},
}
)

cf_client.update_stack(
StackName=stack_name,
TemplateBody=template_json,
Capabilities=["CAPABILITY_NAMED_IAM"],
)

autoscaling_group = autoscaling_client.describe_auto_scaling_groups(
AutoScalingGroupNames=[
autoscaling_group_name,
]
)["AutoScalingGroups"][0]

assert (
autoscaling_group["LaunchTemplate"]["LaunchTemplateName"]
== launch_template_name
)
assert autoscaling_group["LaunchTemplate"]["Version"] == "2"


@mock_autoscaling
@mock_cloudformation
@mock_ec2
def test_asg_with_default_launch_template_version():
cf_client = boto3.client("cloudformation", region_name="us-west-1")
ec2 = boto3.resource("ec2", region_name="us-west-1")
vpc = ec2.create_vpc(CidrBlock="10.0.0.0/16")
autoscaling_client = boto3.client("autoscaling", region_name="us-west-1")

subnet1 = ec2.create_subnet(
CidrBlock="10.0.1.0/24", VpcId=vpc.id, AvailabilityZone="us-west-1a"
)

subnet2 = ec2.create_subnet(
CidrBlock="10.0.2.0/24", VpcId=vpc.id, AvailabilityZone="us-west-1b"
)

autoscaling_group_name = str(uuid4())

stack_name = str(uuid4())
launch_template_name = str(uuid4())[0:6]

version_attribute = "DefaultVersionNumber"

template_json = json.dumps(
{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an ASG group with LaunchTemplate",
"Resources": {
"LaunchTemplate": {
"Type": "AWS::EC2::LaunchTemplate",
"Properties": {
"LaunchTemplateName": launch_template_name,
"LaunchTemplateData": {
"ImageId": EXAMPLE_AMI_ID,
"InstanceType": "t3.small",
"UserData": "",
},
},
},
"AutoScalingGroup": {
"Type": "AWS::AutoScaling::AutoScalingGroup",
"Properties": {
"AutoScalingGroupName": autoscaling_group_name,
"VPCZoneIdentifier": [subnet1.id],
"LaunchTemplate": {
"LaunchTemplateId": {"Ref": "LaunchTemplate"},
"Version": {
"Fn::GetAtt": ["LaunchTemplate", version_attribute]
},
},
"MinSize": 1,
"MaxSize": 1,
},
},
},
}
)

cf_client.create_stack(
StackName=stack_name,
TemplateBody=template_json,
Capabilities=["CAPABILITY_NAMED_IAM"],
OnFailure="DELETE",
)

template_json = json.dumps(
{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an ASG group with LaunchTemplate",
"Resources": {
"LaunchTemplate": {
"Type": "AWS::EC2::LaunchTemplate",
"Properties": {
"LaunchTemplateName": launch_template_name,
"LaunchTemplateData": {
"ImageId": EXAMPLE_AMI_ID2,
"InstanceType": "t3.medium",
"UserData": "",
},
},
},
"AutoScalingGroup": {
"Type": "AWS::AutoScaling::AutoScalingGroup",
"Properties": {
"AutoScalingGroupName": autoscaling_group_name,
"VPCZoneIdentifier": [subnet2.id],
"LaunchTemplate": {
"LaunchTemplateId": {"Ref": "LaunchTemplate"},
"Version": {
"Fn::GetAtt": ["LaunchTemplate", version_attribute]
},
},
"MinSize": 1,
"MaxSize": 2,
},
},
},
}
)

cf_client.update_stack(
StackName=stack_name,
TemplateBody=template_json,
Capabilities=["CAPABILITY_NAMED_IAM"],
)

autoscaling_group = autoscaling_client.describe_auto_scaling_groups(
AutoScalingGroupNames=[
autoscaling_group_name,
]
)["AutoScalingGroups"][0]

assert (
autoscaling_group["LaunchTemplate"]["LaunchTemplateName"]
== launch_template_name
)
assert autoscaling_group["LaunchTemplate"]["Version"] == "1"