Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create multiarch docker image #874

Closed
wants to merge 1 commit into from

Conversation

abemedia
Copy link

@abemedia abemedia commented Aug 13, 2020

Currently the docker images only work on amd64 architecture. This PR adds support for armv7, arm64 and 386.

The versions in the migrate functions are using strings now as the number was too large for 32-bit architectures.

@abemedia abemedia force-pushed the patch-1 branch 4 times, most recently from efb2d82 to 8f91c1d Compare August 14, 2020 18:30
@abemedia abemedia changed the title tooling: build multiarch docker image WIP: tooling: build multiarch docker image Aug 14, 2020
@abemedia abemedia changed the title WIP: tooling: build multiarch docker image chore: create multiarch docker image Aug 14, 2020
@goenning
Copy link
Member

Thanks for the PR and sorry for being slow to respond.

I’m new to buildx so I had to do some research. Have you tried this action here before? https://github.com/docker/build-push-action

I’d prefer using the official Docker actions if possible. Apparently we could even replace that azure docker login as well (which I honestly don’t know I use that...)

Base automatically changed from master to main March 26, 2021 05:58
@abemedia
Copy link
Author

Hi @goenning, thanks for the response.
That action only came out shortly before I did this PR so I hadn't heard of it yet at the time.
Happy to amend this PR to use that though.

Dockerfile Show resolved Hide resolved
@goenning
Copy link
Member

@abemedia thanks for the update. the reason why I went with a separate workflow_run was to publish an image for each pull requests as well, so I'd like to keep that.

  • push to main getfider/fider:main and getfider/fider:SHA_{sha7}
  • pull request: getfider/fider:PR_{number}

@abemedia
Copy link
Author

@goenning still not working as v8go doesn't support these architectures. Currently working on an upstream PR for that.
Is that a new dependency btw? Because I've been using the ARM version in production for months.

As for the PR images that's being done via crazy-max/ghaction-docker-meta which I stumbled across on the docker/build-push-action docs. The naming is slightly different that your current one though (pr-$N instead of PR_$N).

@goenning
Copy link
Member

  1. Yes, v8go is a recent addition.
  2. That won’t work because the workflow doesn’t have access to secrets, which is why I used workflow_run as recommended here https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

@abemedia
Copy link
Author

abemedia commented Mar 28, 2021

OK, will change that back and update the PR once rogchap/v8go#98 is merged.

@goenning goenning marked this pull request as draft November 15, 2021 20:00
@urunimi
Copy link

urunimi commented Nov 27, 2021

@abemedia
It looks like this PR is merged. Do you think this will resolve the v8go issue?
I also need fider for arm64.

@goenning
Copy link
Member

I think we’ll need to wait for rogchap/v8go#223 as well

@abemedia
Copy link
Author

I've been using this branch on ARM for months now. All worked fine.

@urunimi
Copy link

urunimi commented Dec 23, 2021

I've been using this branch on ARM for months now. All worked fine.

Oh, thanks! I'll try to build an image from this branch. @abemedia 👍

@goenning goenning closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants