Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/cargo-c: new package, add 0.9.27 #544

Closed
wants to merge 1 commit into from

Conversation

CyberTailor
Copy link
Contributor

Bug: https://bugs.gentoo.org/917530
Signed-off-by: Anna “CyberTailor” <cyber@sysrq.in>
@orbea
Copy link
Contributor

orbea commented Nov 20, 2023

Thanks for the patch, but as the linked issue claims we are patching this. You can see an example here:

https://github.com/gentoo/libressl/blob/51827245cffe79459a2fa378a34738952926ed6c/dev-util/maturin/files/maturin-1.1.0-libressl-openssl-sys.patch

pushd "${ECARGO_HOME}"/gentoo/openssl-sys-0.9.91 > /dev/null || die
eapply "${FILESDIR}/${PN}-1.1.0-libressl-openssl-sys.patch"
popd > /dev/null || die

The problem is that this crate is vendored in a lot of places and it would be an extreme burden to fix it everywhere and then rebase the fix for every new ebuild in ::gentoo so we are currently only fixing those users are interested in.

Also the issue is wrong about the openssl-sys crate having good reasons, I have never once seen it fail to build because of newer libressl versions except for this extremely inane version check.

@CyberTailor
Copy link
Contributor Author

but as the linked issue claims we are patching this

This is a real PITA to do, I'd prefer the less painful approach.

so we are currently only fixing those users are interested in

I need cargo-c to build media-gfx/libimagequant and sys-libs/pkgcraft.

I have never once seen it fail to build because of newer libressl versions

It could build but work incorrectly.
sfackler/rust-openssl#2035

@orbea
Copy link
Contributor

orbea commented Nov 20, 2023

I need cargo-c to build media-gfx/libimagequant and sys-libs/pkgcraft.

No disagreement with fixing this, I was just explaining why it hasn't already been fixed and why all the other examples aren't being actively fixed. When there is interest as you have shown now they can be fixed.

This is a real PITA to do, I'd prefer the less painful approach.

The whole point of this repo is to use libressl and not a vendored openssl, but the patch only takes a moment to spin up.

It could build but work incorrectly.

I have yet to see this be a problem in practice, but if you know any examples?

@orbea
Copy link
Contributor

orbea commented Nov 21, 2023

@CyberTailor I added cargo-c. 93caad1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants