Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/mpdecimal: Add EPREFIX in configure option to fix build in Gentoo Prefix #36655

Closed
wants to merge 1 commit into from
Closed

dev-libs/mpdecimal: Add EPREFIX in configure option to fix build in Gentoo Prefix #36655

wants to merge 1 commit into from

Conversation

joeydumont
Copy link
Contributor

@joeydumont joeydumont commented May 12, 2024 •
edited

dev-libs/mpdecimal: Add EPREFIX in configure option to fix build in Gentoo Prefix

I haven't added a "Signed-off-by" line because I don't think I am qualified/trusted to do this. EDIT: Signed after reading the documentation about the Certificate of Origin that the bot added to the PR.

In Prefix, I was seeing this error prior to this PR:

>>> Install dev-libs/mpdecimal-4.0.0 into /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image
make -j5 DESTDIR=/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image install 
cd libmpdec && make 
make[1]: Entering directory '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/work/mpdecimal-4.0.0/libmpdec'
make[1]: Nothing to be done for 'default'.
make[1]: Leaving directory '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/work/mpdecimal-4.0.0/libmpdec'
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -d -m 755 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/include
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -d -m 755 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/lib64
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -d -m 755 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/removeme
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -d -m 755 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/lib64/pkgconfig
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -d -m 755 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/share/man/man3
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 644 libmpdec/mpdecimal.h /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/include
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 755 libmpdec/libmpdec.so.4.0.0 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/lib64
cd /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/lib64 && ln -sf libmpdec.so.4.0.0 libmpdec.so.4 && ln -sf libmpdec.so.4.0.0 libmpdec.so
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 644 libmpdec/.pc/libmpdec.pc /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/lib64/pkgconfig
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 644 doc/COPYRIGHT.txt /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/removeme
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 644 doc/mpdecimal.3 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/share/man/man3
/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/bin/install -c -m 644 doc/libmpdec.3 /cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/usr/share/man/man3
rm: cannot remove '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/image/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/removeme': No such file or directory
 * ERROR: dev-libs/mpdecimal-4.0.0::gentoo failed (install phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 136:  Called src_install
 *   environment, line 1515:  Called die
 * The specific snippet of code:
 *       rm -r "${ED}/removeme" || die
 * 
 * If you need support, post the output of `emerge --info '=dev-libs/mpdecimal-4.0.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=dev-libs/mpdecimal-4.0.0::gentoo'`.
 * The complete build log is located at '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/temp/build.log'.
 * The ebuild environment file is located at '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/temp/environment'.
 * Working directory: '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/work/mpdecimal-4.0.0'
 * S: '/cvmfs/software.dumont.ca/2021.02/compat/linux/x86_64/var/tmp/portage/dev-libs/mpdecimal-4.0.0/work/mpdecimal-4.0.0'

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @joeydumont
Areas affected: ebuilds
Packages affected: dev-libs/mpdecimal

dev-libs/mpdecimal: @mgorny

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels May 12, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-12 14:55 UTC
Newest commit scanned: ef545d9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/36ddbcef55/output.html

mgorny
mgorny reviewed May 12, 2024
View reviewed changes
dev-libs/mpdecimal/mpdecimal-4.0.0.ebuild Outdated
@@ -43,7 +43,7 @@ src_prepare() {
src_configure() {
local myconf=(
# just COPYRIGHT.txt
--docdir=/removeme
--docdir="${EPREFIX}"/removeme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. However, could you try changing the rm below to use ${D} rather than ${ED} instead? That should be effectively less roundabout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-12 15:20 UTC
Newest commit scanned: 51e7a78
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3f98055d99/output.html

@joeydumont
dev-libs/mpdecimal: Changed ED to D in install phase to make the ebui…
53cb0ec 
…ld work under Prefix.

Signed-off-by: Joey Dumont <joey.dumont@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-12 19:35 UTC
Newest commit scanned: 53cb0ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f98ddc4bfd/output.html

@mgorny
Copy link
Member

mgorny commented May 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
Milestone
No milestone
4 participants
@joeydumont @gentoo-bot @gentoo-repo-qa-bot @mgorny