Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-devel/bpf-toolchain: new package, add 20240407 #36632

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesamesam
Copy link
Member

@thesamesam thesamesam commented May 10, 2024

Heavily inspired by, and based on, dev-util/mingw64-toolchain. This provides the bpf-unknown-none toolchain for use with DTrace (to be packaged) and systemd.

Users may wish to use crossdev if they want to customise their toolchain - this is "just" a convenience option for e.g. aforementioned ebuilds to depend on and have things Just Work.

TODO:

  • mingw64-toolchain has bin-symlinks custom-cflags debug +strip, do we want/need any of those?

Bug: https://bugs.gentoo.org/917228


Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@thesamesam
Copy link
Member Author

I'll seek review when TODO is addressed, but feel free to comment on the stuff not covered by that.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: sys-devel/bpf-toolchain

sys-devel/bpf-toolchain: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 917228

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 10, 2024
Comment on lines 172 to 170
bpft-build binutils
bpft-build gcc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't need multi-stage bootstrapping, is it really necessary to be combined in 1 ebuild? Was under the impression the process was going to be more involved.

Arguably mingw64-toolchain could've split out binutils too, but still had to combine w/ runtime for the multi-stage builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not that I think of it as a problem if just want to keep things in one place in a similar manner)

Heavily inspired by, and based on, dev-util/mingw64-toolchain. This provides
the bpf-unknown-none toolchain for use with DTrace (to be packaged) and
systemd.

Users may wish to use crossdev if they want to customise their toolchain -
this is "just" a convenience option for e.g. aforementioned ebuilds to depend
on and have things Just Work.

TODO:
* mingw64-toolchain has bin-symlinks custom-cflags debug +strip, do we
  want/need any of those?

Bug: https://bugs.gentoo.org/917228
Signed-off-by: Sam James <sam@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-11 00:19 UTC
Newest commit scanned: 6376769
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/98a72a8c7e/output.html#sys-devel/bpf-toolchain

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/98a72a8c7e/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants