New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-devel/bpf-toolchain: new package, add 20240407 #36632
base: master
Are you sure you want to change the base?
Conversation
I'll seek review when TODO is addressed, but feel free to comment on the stuff not covered by that. |
Pull Request assignmentSubmitter: @thesamesam sys-devel/bpf-toolchain: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 917228 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
f95effa
to
c672112
Compare
bpft-build binutils | ||
bpft-build gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't need multi-stage bootstrapping, is it really necessary to be combined in 1 ebuild? Was under the impression the process was going to be more involved.
Arguably mingw64-toolchain could've split out binutils too, but still had to combine w/ runtime for the multi-stage builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not that I think of it as a problem if just want to keep things in one place in a similar manner)
Heavily inspired by, and based on, dev-util/mingw64-toolchain. This provides the bpf-unknown-none toolchain for use with DTrace (to be packaged) and systemd. Users may wish to use crossdev if they want to customise their toolchain - this is "just" a convenience option for e.g. aforementioned ebuilds to depend on and have things Just Work. TODO: * mingw64-toolchain has bin-symlinks custom-cflags debug +strip, do we want/need any of those? Bug: https://bugs.gentoo.org/917228 Signed-off-by: Sam James <sam@gentoo.org>
Pull request CI reportReport generated at: 2024-05-11 00:19 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Heavily inspired by, and based on, dev-util/mingw64-toolchain. This provides the bpf-unknown-none toolchain for use with DTrace (to be packaged) and systemd.
Users may wish to use crossdev if they want to customise their toolchain - this is "just" a convenience option for e.g. aforementioned ebuilds to depend on and have things Just Work.
TODO:
Bug: https://bugs.gentoo.org/917228
Please check all the boxes that apply:
Signed-off-by
line to every commit in the pull request.pkgcheck scan --commits --net
to check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.