Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/*: bump version, fix warnings #764

Merged
merged 6 commits into from
Dec 3, 2023
Merged

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Apr 8, 2023

Changes

  • Bump the actions/checkout version to v3 throughout all workflows. [This fixes the Node 12 deprecation warnings displayed under the Annotations section in Actions, as newer versions of it use Node 16]
  • Fix missing eol in all workflow files.
  • Under flatpak.yml, bump
    • The flatpak-builder version to the latest version v6.
    • Update container image to GNOME 44.
    • docker/setup-qemu-action to v2. [This fixes the Node 12 deprecation warnings displayed under the Annotations section in Actions, as newer versions of it use Node 16]

Testing

All the above changes have been tested in my fork before creating a PR, the action runs can be found here https://github.com/kbdharun/cozy/actions.

Notes

As expected, the aarch runners will take extra time as it is not supported by GitHub Actions [which only have x86_64 runners] flatpak builder works around this using qemu which leads to longer workflow times, fortunately, GitHub seems to be working on ARM runners in the near future (actions/runner-images#5631) so let us hope for the best.

@geigi
Copy link
Owner

geigi commented Dec 3, 2023

Looks good, thanks for your contribution!

@geigi geigi merged commit b3867f7 into geigi:master Dec 3, 2023
@kbdharun
Copy link
Contributor Author

kbdharun commented Dec 3, 2023

Looks good, thanks for your contribution!

Thanks, I totally forgot about this PR 😅 , actions/checkout v4 and GNOME 45 are out now. Will create a new PR IG.

Edit. Done #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants