Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dependency in pyoxidizer build #323

Merged
merged 1 commit into from
Jan 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions client/gefyra/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ def version(config, check: bool):
f"You are using gefyra version {config.__VERSION__}; however, version {latest_release_version} is "
f"available."
)
return True


def telemetry_command(on, off):
Expand Down
4 changes: 2 additions & 2 deletions client/pyoxidizer.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def make_exe():
exe.add_python_resources(exe.read_package_root(CWD, ["gefyra"]))
exe.add_python_resources(exe.pip_install(["--no-deps", "docker==6.0.1"]))
# certifi from version 2022.06.15.1 does not work
exe.add_python_resources(exe.pip_install(["certifi==2022.06.15", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
exe.add_python_resources(exe.pip_install(["chardet", "certifi==2022.06.15", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
return exe

def make_win_exe():
Expand Down Expand Up @@ -74,7 +74,7 @@ def make_win_exe():
exe.add_python_resources(exe.read_package_root(CWD, ["gefyra"]))
exe.add_python_resources(exe.pip_install(["--no-deps", "docker==6.0.1"]))
# certifi from version 2022.06.15.1 does not work
exe.add_python_resources(exe.pip_install(["certifi==2022.06.15", "pywin32", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
exe.add_python_resources(exe.pip_install(["chardet", "certifi==2022.06.15", "pywin32", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
exe.windows_runtime_dlls_mode = "always"
return exe

Expand Down