Merge pull request #323 from gefyrahq/fix-chardet

fix: missing dependency in pyoxidizer build
gefyrahq · Jan 17, 2023 · 7f77564 · 7f77564
2 parents 3aeba2d + 8e76e18
commit 7f77564
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/client/gefyra/__main__.py b/client/gefyra/__main__.py
@@ -261,6 +261,7 @@ def version(config, check: bool):
                 f"You are using gefyra version {config.__VERSION__}; however, version {latest_release_version} is "
                 f"available."
             )
+    return True
 
 
 def telemetry_command(on, off):

diff --git a/client/pyoxidizer.bzl b/client/pyoxidizer.bzl
@@ -40,7 +40,7 @@ def make_exe():
     exe.add_python_resources(exe.read_package_root(CWD, ["gefyra"]))
     exe.add_python_resources(exe.pip_install(["--no-deps", "docker==6.0.1"]))
     # certifi from version 2022.06.15.1 does not work
-    exe.add_python_resources(exe.pip_install(["certifi==2022.06.15", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
+    exe.add_python_resources(exe.pip_install(["chardet", "certifi==2022.06.15", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
     return exe
 
 def make_win_exe():
@@ -74,7 +74,7 @@ def make_win_exe():
     exe.add_python_resources(exe.read_package_root(CWD, ["gefyra"]))
     exe.add_python_resources(exe.pip_install(["--no-deps", "docker==6.0.1"]))
     # certifi from version 2022.06.15.1 does not work
-    exe.add_python_resources(exe.pip_install(["certifi==2022.06.15", "pywin32", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
+    exe.add_python_resources(exe.pip_install(["chardet", "certifi==2022.06.15", "pywin32", "kubernetes", "packaging==21.3", "tabulate", "cli-tracker"]))
     exe.windows_runtime_dlls_mode = "always"
     return exe