fixes #716 Improve missing terminal error message. #717
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am willing to either further improve the error message or the project documentation to help users avoid this issue in the future. |
luisdavim
reviewed
Apr 1, 2024
terms_dynamic.go
Outdated
| @@ -30,6 +30,9 @@ import ( | |||
| ) | |||
|
|
|||
| func loadDynamicTerminfo(term string) (*terminfo.Terminfo, error) { | |||
| if term == "" { | |||
| return nil, ErrTermNotFound | |||
There was a problem hiding this comment.
nit: maybe wrap this with "term not set" or something like that?
return nil, fmt.Errorf("%w: term not set",ErrTermNotFound)that could make it even easier to debug.
There was a problem hiding this comment.
I've made the requested change to the pull request.
gdamore
reviewed
Oct 6, 2024
| @@ -27,9 +27,14 @@ import ( | |||
| // will be automatically included anyway. | |||
| "github.com/gdamore/tcell/v2/terminfo" | |||
| "github.com/gdamore/tcell/v2/terminfo/dynamic" | |||
|
|
|||
| "fmt" | |||
There was a problem hiding this comment.
Normally I prefer fmt to be (standard lib) imports first, but in this case I think it might be fine because of the comment above the others.
gdamore
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in debug mode in VS Code under Linux the Application.Run() method returns an *os/exec.ExitError . This is very confusing and makes tracking down the root cause difficult.
The issue is caused by the default debug environment in VS Code not launching in a terminal.
The error message can be improved by returning an ErrTermNotFound in the case of an empty $TERM environment variable. Hopefully a better error message will lead users to identify the lack of a terminal as the root cause of the problem.