fix(gatsby-source-contentful): don't call createNode on null
#37958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: source-contentful
LekoArts
approved these changes
Apr 19, 2023
LekoArts
changed the title
createNode on null
LekoArts
pushed a commit
that referenced
this pull request
Apr 19, 2023
) (cherry picked from commit da9a8f5)
LekoArts
pushed a commit
that referenced
this pull request
Apr 19, 2023
) (#37960) Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
|
Successfully published:
|
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a small regression in #37910.
entryNodeitems may be null via https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-contentful/src/normalize.js#L496. This PR just checks that the entry node item exists before callingcreateNodeon it