Revert "fix(gatsby): Update mini-css-extract-plugin to fix inc builds issue (#33979)" #34413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: core
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
2 tasks
ESnark
added a commit
to ESnark/gatsby-starter-developer-diary
that referenced
this pull request
Nov 15, 2023
An error occurs during build time: Error: ObjectMiddleware.register: serializer for mini-css-extract-plugin/dist/CssModule/null is already registered Possible causes: gatsbyjs/gatsby#34413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This partially reverts commit 725dc36.
While #33979 fixed #33450 issues with e.g.
raw-loadershowed up. The syntax for inline loader syntax changed: https://webpack.js.org/guides/asset-modules/#replacing-inline-loader-syntaxIt's a breaking change we can't make 😢
We'll need to revert the actual change (but keep the tests from the PR) and do this in the next major of Gatsby.
Note: Probably should use
assetinstead ofasset/resourcein next PR to have base64 inlining working.Related Issues
#33979
#33450