callback isn't needed

gatsbyjs · Mar 24, 2023 · 7ff48c7 · 7ff48c7
1 parent 72d4373
commit 7ff48c7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/packages/gatsby/src/redux/reducers/inference-metadata.ts b/packages/gatsby/src/redux/reducers/inference-metadata.ts
@@ -37,15 +37,13 @@ const incrementalReducer = (
 
     case `BUILD_TYPE_METADATA`: {
       // Overwrites existing metadata
-      const { nodes, typeName, clearExistingMetadata, callback } =
-        action.payload
+      const { nodes, typeName, clearExistingMetadata } = action.payload
       if (!state[typeName]?.ignored) {
         const initialMetadata = clearExistingMetadata
           ? initialTypeMetadata()
           : state[typeName]
 
         state[typeName] = addNodes(initialMetadata, nodes)
-        callback()
       }
       return state
     }

diff --git a/packages/gatsby/src/redux/types.ts b/packages/gatsby/src/redux/types.ts
@@ -1058,7 +1058,6 @@ interface IBuildTypeMetadataAction {
     nodes: Array<IGatsbyNode>
     clearExistingMetadata: boolean
     typeName: string
-    callback: () => void
   }
 }
 

diff --git a/packages/gatsby/src/schema/index.js b/packages/gatsby/src/schema/index.js
@@ -74,14 +74,14 @@ const buildInferenceMetadata = ({ types }) =>
               // only clear metadata on the first chunk for this type
               clearExistingMetadata: dispatchCount++ === 0,
               nodes: processingNodes,
-              callback: () => {
-                processingNodes = []
-                setImmediate(() => {
-                  res(null)
-                })
-              },
             },
           })
+          setImmediate(() => {
+            processingNodes = []
+            setImmediate(() => {
+              res(null)
+            })
+          })
         })
       }