Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gardener-apiserver keeps serving /openapi/v2 endpoint #8577

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area usability
/kind regression

What this PR does / why we need it:
When gardener-apiserver does not serve the /openapi/v2 endpoint, users without permissions to list CustomResourceDefinitions might see the following error when using a kubectl version lower than 1.27 and trying to interact with the Gardener APIs:

error: error validating "github.com/gardener/gardener/example/provider-local/shoot-workerless.yaml": error validating data: failed to check CRD: failed to list CRDs: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:default:foo" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope; if you choose to ignore these errors, turn validation off with --validate=false

Introduced with #8464

Special notes for your reviewer:
/cc @acumino @dguendisch @timuthy @ary1992

Release note:

A bug has been fixed that prevented users without permissions to list `CustomResourceDefinition`s from interacting with the Gardener APIs when using a `kubectl` version lower than `1.27`.

@gardener-prow gardener-prow bot added area/usability Usability related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Sep 29, 2023
@rfranzke
Copy link
Member Author

/cherry-pick release-v1.80

@gardener-ci-robot
Copy link
Contributor

@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.80 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.80

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2023
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 29, 2023

LGTM label has been added.

Git tree hash: 62f7fe9c56c74add86589574df9096e0b11a46f6

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@gardener-prow gardener-prow bot merged commit ec114c5 into gardener:master Sep 29, 2023
16 checks passed
@gardener-ci-robot
Copy link
Contributor

@rfranzke: new pull request created: #8580

In response to this:

/cherry-pick release-v1.80

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants