Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.72] Enhance Webhook remediator #8045

Merged
merged 2 commits into from
Jun 8, 2023
Merged

[release-v1.72] Enhance Webhook remediator #8045

merged 2 commits into from
Jun 8, 2023

Conversation

gardener-ci-robot
Copy link
Contributor

This is an automated cherry-pick of #8034

/assign acumino

Webhooks remediator sets the timeoutSeonds to 3 seconds for webhook affecting lease resources in `kube-system` namespace only if there is no objectSelector provided in webhook.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Jun 7, 2023
Merged
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2023
acumino
acumino reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. kind/bug Bug labels Jun 7, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 7, 2023

LGTM label has been added.

Git tree hash: 2b0108f38a01ca4a8f8249b042b6e0594772cac8

@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 7, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@shafeeqes
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot merged commit dcdefb2 into gardener:release-v1.72 Jun 8, 2023
15 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-8034-to-release-v1.72 branch July 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@rfranzke rfranzke Awaiting requested review from rfranzke

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees

@acumino acumino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gardener-ci-robot @shafeeqes @acumino