Revert recently introduced low timeouts for several steps #8005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: shafeeqes <shafeeque.e.s@sap.com> Co-authored-by: acumino <sonu.kumar.singh02@sap.com> Co-authored-by: kon-angelo <konstantinos.angelopoulos@sap.com>
gardener-prow
bot
added
area/control-plane
gardener-prow
bot
added
the
size/S
acumino
reviewed
May 31, 2023
|
LGTM label has been added. Git tree hash: 4b706eced3c8893976402ed53919e7942353ed2f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/cherry-pick release-v1.71 |
|
@ialidzhikov: new pull request created: #8006 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
In aa2f8c0 several new timeouts were introduced for several steps (previously timeouts for these steps were not existing).
These new timeouts cause the reconciliation to never succeed. For example a ControlPlane/Network reconciliation for a given Shoot takes almost always more than 30s. In such case, gardenlet can never succeed reconciling the given Shoot.
We should investigate also the extensions - why it takes that much time for them to reconcile the ControlPlane/Network.
Which issue(s) this PR fixes:
See above.
Special notes for your reviewer:
N/A
Release note: