Drop core/v1alpha1 API version
#7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
the
size/XXL
|
/retest |
gardener-prow
bot
added
the
needs-rebase
|
/assign |
shafeeqes
reviewed
May 23, 2023
There was a problem hiding this comment.
Thanks for the PR.
example/81-exposureclass.yamlanddocs/usage/exposureclasses.mdstill uses v1alpha1..golangci.yamlfile needs to be adapted.- Also, gardenlet is stuck at
{"level":"info","ts":"2023-05-23T03:41:50.875Z","msg":"Waiting until the namespace has been cleaned up and deleted in the Seed cluster","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c3691032-a9ae-4d35-8498-9fe7a3812f4d","operation":"delete","namespaceName":"shoot--local--local"}
during deletion.
Checking the shoot namespace,
- lastTransitionTime: "2023-05-23T03:40:20Z"
message: 'Discovery failed for some groups, 1 failing: unable to retrieve the
complete list of server APIs: core.gardener.cloud/v1alpha1: the server is currently
unable to handle the request'
reason: DiscoveryFailed
status: "True"
type: NamespaceDeletionDiscoveryFailure
shafeeqes
reviewed
May 23, 2023
ary1992
force-pushed
the
enh/drop-v1alpha1
branch
from
9646613
to
79220da
Compare
ary1992
force-pushed
the
enh/drop-v1alpha1
branch
from
79220da
to
efa59bc
Compare
gardener-prow
bot
removed
the
needs-rebase
|
/retest |
ary1992
force-pushed
the
enh/drop-v1alpha1
branch
from
efa59bc
to
4609e22
Compare
|
/retest |
|
LGTM label has been added. Git tree hash: fff2099004c592cb4d23dfba7b89a84f25eb45c9
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
andrerun
pushed a commit
to andrerun/gardener
that referenced
this pull request
Jul 6, 2023
* BackupBucket * BackupEntry * ControllerDeployment * ControllerInstallation * ControllerRegistration * ExposureClass * SecretBinding * Quota * ShootState * Shoot * Project * Seed * CloudProfile * Drop pkg/apis/core/v1aplha1 folder * Adapt Bastion * Remove v1alpha1 occurances * Update update-codegen.sh * make generate * Update Skaffold * Delete apiservice-v1alpha1-core-gardener-cloud.yaml * Address PR review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Drop the
core/v1alpha1API version.Which issue(s) this PR fixes:
Fixes #7358
Special notes for your reviewer:
Release note: