Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new dashboard of seed deployment replicas #7896

Merged
merged 2 commits into from
May 22, 2023
Merged

add new dashboard of seed deployment replicas #7896

merged 2 commits into from
May 22, 2023

Conversation

Sallyan
Copy link
Contributor

@Sallyan Sallyan commented May 9, 2023

How to categorize this PR?

/area monitoring
/area ops-productivity
/kind enhancement

What this PR does / why we need it:
This PR is adding new grafana dashboard of deployment replicas for seed extensions and other components which not in kube-system and garden namespace.
It helps to identify downtimes in the respective components.

Which issue(s) this PR fixes:
Fixes # #7387

Special notes for your reviewer:

Release note:

Add new grafana dashboard of seed deployment replicas

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) labels May 9, 2023
@gardener-prow gardener-prow bot requested review from rfranzke and timebertt May 9, 2023 06:39
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 9, 2023

Hi @Sallyan. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2023
rfranzke
rfranzke reviewed May 9, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/cc @istvanballok @rickardsjp

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2023
@Sallyan
Copy link
Contributor Author

Sallyan commented May 9, 2023

It gets all deployments which not in garden and kube-system namespace, as there is no StatetefulSets or DaemonSets .
Screenshot 2023-05-09 at 13 57 28

For deployment istio-ingressgateway, it might have regional multiple istio-ingress so the panels show replica status group by namesapce.

Screenshot 2023-05-09 at 14 13 58

rickardsjp
rickardsjp suggested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@rickardsjp rickardsjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I had only two nits to pick.

charts/seed-bootstrap/dashboards/seed-deployments-replicas.json Outdated Show resolved Hide resolved
charts/seed-bootstrap/dashboards/seed-deployments-replicas.json Show resolved Hide resolved
@Sallyan Sallyan requested a review from rickardsjp May 18, 2023 02:47
rickardsjp
rickardsjp approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@rickardsjp rickardsjp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 🎉

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 18, 2023

LGTM label has been added.

Git tree hash: bc0a0cd7ceb8835e7f7473dfb813d84bc76bb7e9

@Sallyan
Copy link
Contributor Author

Sallyan commented May 19, 2023

/milestone v1.71

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 19, 2023

@Sallyan: You must be a member of the gardener/gardener-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.71

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rfranzke
rfranzke reviewed May 19, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke, rickardsjp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@shafeeqes
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot merged commit d6481d6 into gardener:master May 22, 2023
16 checks passed
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@Sallyan @andrerun
add new dashboard of seed deployment replicas (gardener#7896)
2f7d6eb 
* add new dashboard of seed deployment replicas

* update title and panel decimals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@rickardsjp rickardsjp rickardsjp approved these changes

@timebertt timebertt Awaiting requested review from timebertt

@istvanballok istvanballok Awaiting requested review from istvanballok

Assignees

@rickardsjp rickardsjp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sallyan @shafeeqes @rickardsjp @rfranzke