Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feature resolution #2274

Merged
merged 2 commits into from Mar 17, 2023
Merged

fix: feature resolution #2274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f79913a
fix: feature resolution
DaniPopes Mar 16, 2023
73ebf72
docs: add comment explaining resolver
DaniPopes Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions Cargo.toml
View file
Open in desktop
Expand Up @@ -58,6 +58,8 @@ default-members = [
"ethers-solc",
]

resolver = "2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL
https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html

so if the crate does not use edition 2021 it falls back to old resolver unless the dependency uses resolver 2?

man I wonder how much time will be wasted on debugging problems this is causing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah there it is, virtual workspaces default to v1. Crazy


[workspace.dependencies]
# workspace crates
ethers = { version = "2.0.0", path = "ethers", default-features = false }
Expand All @@ -77,11 +79,11 @@ ethers-derive-eip712 = { version = "2.0.0", path = "ethers-core/ethers-derive-ei
# async / async utils
tokio = "1.26"
tokio-tungstenite = { version = "0.18.0", default-features = false }
futures = { version = "0.3.27", default-features = false }
futures-core = { version = "0.3.27", default-features = false }
futures-util = { version = "0.3.27", default-features = false }
futures-executor = { version = "0.3.27", default-features = false }
futures-channel = { version = "0.3.27", default-features = false }
futures = { version = "0.3.27", default-features = false, features = ["std"] }
futures-core = "0.3.27"
futures-util = "0.3.27"
futures-executor = "0.3.27"
futures-channel = "0.3.27"
futures-locks = { version = "0.7.1", default-features = false }
futures-timer = { version = "3.0.2", default-features = false, features = ["wasm-bindgen"] }
pin-project = "1.0"
Expand All @@ -103,7 +105,7 @@ serde_json = "1.0"
# macros
proc-macro2 = "1.0"
quote = "1.0"
syn = "1.0"
syn = { version = "1.0", features = ["extra-traits"] }
async-trait = "0.1.66"
auto_impl = "1.0"

Expand Down
2 changes: 1 addition & 1 deletion ethers-contract/ethers-contract-abigen/Cargo.toml
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ ethers-core = { workspace = true, features = ["macros"] }

proc-macro2.workspace = true
quote.workspace = true
syn = { workspace = true, features = ["full"] }
syn.workspace = true
prettyplease = "0.1.25"

Inflector = "0.11"
Expand Down