Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): properly parse genesis alloc storage #2205

Merged
merged 3 commits into from Feb 27, 2023
Merged

fix(core): properly parse genesis alloc storage #2205

merged 3 commits into from Feb 27, 2023

Commits on Feb 27, 2023

  1. fix(core): properly parse genesis alloc storage 

     * Previously we were not properly parsing the storage field of
   GenesisAlloc. The first issue was in using serde(flatten), which is
   just incorrect because storage is not encoded flattened. The second
   issue was in the parsing of H256 keys and values. Some of the storage
   values in hive genesis examples were encoded in less than 64 hex
   characters, such as the string `0x12`. This would not succeed normal
   H256 parsing.
 * Introduce from_unformatted_hex_map to properly deserialize the
   storage map.
 * Modify existing genesis parsing tests to check parsed storage and
   code values against expected values.
 * Introduce new genesis parsing test from the hive smoke tests,
   checking full struct equality.
    @Rjected
    Rjected committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    1a5e25b View commit details
    Browse the repository at this point in the history

  2. remove unused from_unformatted hex

    @Rjected
    Rjected committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7438cf5 View commit details
    Browse the repository at this point in the history

  3. make clippy happy

    @Rjected
    Rjected committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    800be06 View commit details
    Browse the repository at this point in the history