Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(contract): derive procedural macros #2152

Merged
merged 11 commits into from Feb 14, 2023
Merged

refactor(contract): derive procedural macros #2152

merged 11 commits into from Feb 14, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 13, 2023 •
edited

Motivation

Requires #2149

Solution

  • Make error handling consistent by using Result<_, syn::Error>
  • Format quote! macro inputs
  • Use syn::Generics::split_for_impl instead of manually parsing generics
  • Use eyre::Result (inherited from ethers_contract_abigen) instead of Box<dyn std::error::Error>

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@DaniPopes DaniPopes marked this pull request as draft February 13, 2023 23:53
@gakonst
Copy link
Owner

gakonst commented Feb 14, 2023

#2149 is now merged!

@DaniPopes DaniPopes marked this pull request as ready for review February 14, 2023 01:38
@gakonst gakonst merged commit d859720 into gakonst:master Feb 14, 2023
@DaniPopes DaniPopes deleted the refactor/contract-derives branch February 14, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniPopes @gakonst